chore(e2e): wait for toggle to be checked with retries #5124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
reviewed
Nov 16, 2023
gribnoysup
force-pushed
the
try-to-fix-e2e-flake
branch
from
f0595b0 to
0b47403
Compare
addaleax
approved these changes
Nov 16, 2023
Comment on lines
179
to
186
| try { | ||
| expect(await acceptTOSToggle.getAttribute('aria-checked')).to.eq( | ||
| 'true' | ||
| ); | ||
| return true; | ||
| } catch { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
This is the same, right?
Suggested change
| try { | |
| expect(await acceptTOSToggle.getAttribute('aria-checked')).to.eq( | |
| 'true' | |
| ); | |
| return true; | |
| } catch { | |
| return false; | |
| } | |
| return await acceptTOSToggle.getAttribute('aria-checked')) === 'true'; |
There was a problem hiding this comment.
I wanted to keep the assertion to make it clear that we are not just waiting for something, but asserting it. Don't have a strong preference though, will update (waitUntil will loose the assertion error anyway, no way to propagate it)
There was a problem hiding this comment.
And pushed again
There was a problem hiding this comment.
Yeah, I understand, but I also get why (almost?) all of our other waitUntil usage is using the return-a-boolean-directly approach, might be worth keeping it consistent?
There was a problem hiding this comment.
Totally, will keep it consistent
gribnoysup
force-pushed
the
try-to-fix-e2e-flake
branch
from
0b47403 to
324181f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the screenshot in CI this "should allow to accept TOS when signed in" test fails because we check just a moment too early, you can kinda see the toggle being mid-switch animation. I'm adding a
waitFormethod similar to testing-librarywaitForso that we can retry a few times to hopefully reduce the flake here