Skip to content

test(connection-storage): exported connections tests COMPASS-7464 COMPASS-7392 #5125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Nov 28, 2023
Merged

test(connection-storage): exported connections tests COMPASS-7464 COMPASS-7392 #5125

merged 16 commits into from
Nov 28, 2023

Conversation

mabaasit
Copy link
Collaborator

Description

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@mabaasit mabaasit changed the title test(connection-storage): migrate to safeStorage COMPASS-7464 test(connection-storage): migrate to safeStorage COMPASS-7464 COMPASS-7392 Nov 16, 2023
@lerouxb
Copy link
Contributor

lerouxb commented Nov 28, 2023

Is this PR title correct? It only adds tests, it doesn't migrate to safeStorage, right?

@mabaasit mabaasit changed the title test(connection-storage): migrate to safeStorage COMPASS-7464 COMPASS-7392 test(connection-storage): exported connections tests COMPASS-7464 COMPASS-7392 Nov 28, 2023
@mabaasit
Copy link
Collaborator Author

Is this PR title correct? It only adds tests, it doesn't migrate to safeStorage, right?

I modified it. This PR just adds test to the existing migration code.

Base automatically changed from safe-storage to main November 28, 2023 16:19
@mabaasit mabaasit added the no release notes Fix or feature not for release notes label Nov 28, 2023
@mabaasit mabaasit merged commit 85485a2 into main Nov 28, 2023
@mabaasit mabaasit deleted the COMPASS-7464-connection-tests branch November 28, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lerouxb lerouxb lerouxb approved these changes

Assignees

No one assigned

Labels

no release notes Fix or feature not for release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mabaasit @lerouxb