chore(connection-form): use mongodb dep only with types VSCODE-488 #5197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
approved these changes
Dec 6, 2023
himanshusinghs
approved these changes
Dec 6, 2023
|
Good thinking Sergey, I'll merge this for now to unblock VSCode work, and look into a lint rule now. |
addaleax
reviewed
Dec 7, 2023
| { | ||
| title: 'Nearest', | ||
| id: MongoReadPreference.NEAREST, | ||
| id: 'nearest', |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCODE-488
This is so we can exclude it from the webview webpack in VSCODE without erroring. We could alternatively add a lot of polyfills (os-browserify path-browserify stream-http timers-browserify url util browserify-zlib) and keep it included. Excluding it seems a bit simpler and probably reduces bundle size.