feat: add ChangeView component to bulk update preview #5209
Conversation
lerouxb
added
the
feature flagged
| return obj.changeType; | ||
| } | ||
|
|
||
| export function unifyDocuments( |
There was a problem hiding this comment.
Maybe start here. GitHub collapsed this file..
| color: palette.gray.dark2, | ||
| }); | ||
|
|
||
| export function ChangeView({ |
There was a problem hiding this comment.
GitHub collapsed this file, but this is a good entry-point for the component if you prefer to read from that end.
| ? lookupValue((obj.right as Branch).path, right) | ||
| : undefined; | ||
|
|
||
| // TODO: BSONValue does not always show the bson type, so you can't spot bson type changes |
There was a problem hiding this comment.
TODO is not really the right word, but I did want to call attention to this. Since we're using the same components as the Document component the BSON values behave the same. So a Double with the value of 1 or an Int32 with value 1 or a Long with the value 1 all look the same.
This might not be much of a problem. As long we keep the before/after values with their types they will be stringified as new Double(1), new Int32(1) and new Long(1) respectively before being diffed and therefore it will show up as changed. But the "red" and "green" values will then look identical.
I just bring this up because during tech design some people mentioned bson type changes.
There was a problem hiding this comment.
(I removed the TODO)
packages/compass-crud/src/components/change-view/shape-utils.ts
Outdated
Show resolved
Hide resolved
2 participants
To review: Maybe start with
unifyDocuments()inunified-document.ts. Or alternatively just theChangeViewcomponent inchange-view.tsx. Don't be intimidated by the line count - it is almost all test fixtures' expected results.