feat(sidebar): disable clicking on the performance tab when unsupported in Atlas #5235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
force-pushed
the
gray-out-performance-tab-for-atlas
branch
from
8e0ef73 to
979cdfe
Compare
lerouxb
reviewed
Dec 14, 2023
gribnoysup
commented
Dec 14, 2023
|
|
||
| // Checking if "Performance" tab is supported by running commands required for | ||
| // the "Performance" tab to function | ||
| void Promise.all([dataService.currentOp(), dataService.top()]).then( |
There was a problem hiding this comment.
@mcasimir this check looks good to you? Anything else you'd want to see here?
|
Pushed some updates based on product feedback |
mabaasit
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When commands required for performance tab are failing and the error is atlas error, we show the Performance item as grayed out and also show a tooltip with text explaining why
Some questions I asked product: