Skip to content

fix(aggregations): pass object to the get schema; make sure get schema handles recursive deps #5241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2023
Merged

fix(aggregations): pass object to the get schema; make sure get schema handles recursive deps #5241

merged 1 commit into from
Dec 15, 2023

Conversation

gribnoysup
Copy link
Collaborator

Fixes two issues:

  • we started passing HadronDocuments to the get schema instead of the actual objects leading to incorrect schema being calculated
  • get schema wasn't handling potentially recursive objects well, failing with stack overflow in those cases

@gribnoysup gribnoysup added the no release notes Fix or feature not for release notes label Dec 15, 2023
@github-actions github-actions bot added the fix label Dec 15, 2023
@gribnoysup
Copy link
Collaborator Author

"No release notes" because it's not an issue in GA

@gribnoysup gribnoysup merged commit 7b9bbc1 into main Dec 15, 2023
@gribnoysup gribnoysup deleted the fix-get-schema-recursive-obj branch December 15, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@Anemy Anemy Anemy approved these changes

Assignees

No one assigned

Labels

fix no release notes Fix or feature not for release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gribnoysup @addaleax @Anemy