chore(build): notarize dmg COMPASS-7489 #5354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
requested changes
Jan 17, 2024
| debug('macnotary result:', macnotaryResult.stdout, macnotaryResult.stderr); | ||
| debug('ls', (await execFile('ls', ['-lh'], { cwd: path.dirname(src), encoding: 'utf8' })).stdout); | ||
|
|
||
| // Step:3 - clean up. remove existing src, unzip signedArchive to src, remove signedArchive and unsignedArchive |
There was a problem hiding this comment.
q: do you think we need to be concerned about clean up resources (step 3 here) if step 1/step 2 fails? as it's written, if anything throws (including any step in the cleanup), we won't clean up any temporary files.
There was a problem hiding this comment.
if for some reason any step here fails, the whole build process will fail.
There was a problem hiding this comment.
Not a big deal, but since is not a big effort, it may be nice to move the removal calls in a finally block.
mcasimir
reviewed
Jan 18, 2024
| // eslint-disable-next-line strict | ||
| 'use strict'; | ||
| const chalk = require('chalk'); | ||
| const childProcess = require('child_process'); |
There was a problem hiding this comment.
Nice seeing some line of code leaving this file! :)
mcasimir
approved these changes
Jan 18, 2024
addaleax
approved these changes
Jan 18, 2024
baileympearson
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes