-
Notifications
You must be signed in to change notification settings - Fork 234
COMPASS-80 add databases view + collections table #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9891315
to
5aefed9
Compare
const React = require('react'); | ||
const app = require('ampersand-app'); | ||
const CollectionsActions = require('../actions/collections-actions'); | ||
const SortableTable = app.appRegistry.getComponent('App.SortableTable'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this into the contructor please? See: https://github.com/10gen/compass/blob/master/src/internal-packages/server-stats/lib/component/databases-table.jsx#L17
The only reason this does work is that the app
package is loaded before the database
package but the order in which packages are loaded will never be guaranteed and should not be depended on.
Just the one thing to address from me then LGTM. If you guys can't get to it today then I'll take care of it. |
bd9d95d
to
095e3d4
Compare
@durran, this latest rebase + force push messed up my local branch. Could you add the following line in
That will cause the zero state to go to the "empty" namespace, which is the instance level. |
Some larger refactors in this PR:
internal-packages/app
(use this as shared components home for now)internal-packages/database
package, with a single tab "Collections" and a CollectionsTable view./src/app/home
maintains the state for navigating between all main views (i.e. not "Connect")Current state: Collections are in a table but InstanceStore doesn't actually contain most information required at this level, e.g. size of each collection. This only happens once we click on a collection. So we need to go and fetch all that info in the store (async.parallel ?)