chore(e2e): Rewrite Instance Databases tab -> can refresh the list of databases using refresh controls COMPASS-7663 #5544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
approved these changes
Mar 6, 2024
lerouxb
commented
Mar 6, 2024
| await browser.pause(1000); | ||
| await browser.clickVisible(Selectors.InstanceRefreshDatabaseButton); | ||
| // Refresh again and the database card should disappear. | ||
| await browser.clickVisible(Selectors.InstanceRefreshDatabaseButton, { |
There was a problem hiding this comment.
Sometimes the card doesn't go away. This is now the only time we hit the refresh button so the only thing I can think of is that the initial load is still somehow in progress by the time we hit the refresh button.
lerouxb
commented
Mar 6, 2024
| // Wait for the page to finish loading as best as we can | ||
| await browser.waitUntil(async () => { | ||
| const placeholders = await browser.$$(Selectors.DatabaseStatLoader); | ||
| return placeholders.length === 0; |
There was a problem hiding this comment.
If only we (or a user) could reliably tell in the UI once everything is done loading. 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than wait for one of https://jira.mongodb.org/browse/COMPASS-7695 or https://jira.mongodb.org/browse/COMPASS-7696 or disabling the test in the meantime I just rewrote it to do less and just check that the button works in the shortest number of steps for now.
I think there was also a race condition in there somewhere but I'm pretty confident that it won't affect real users and I've spent weeks debugging this off and on now. I really just want this test to stop flaking regularly because it keeps failing CI.