Skip to content

COMPASS-144 call stopPropagation() when cancel clicked #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2016
Merged

COMPASS-144 call stopPropagation() when cancel clicked #565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a0951b
COMPASS-144 call stopPropagation() when cancel clicked
Nov 3, 2016
c0c1b85
switch to preventDefault() because it’s less invasive.
Nov 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/auto-update/index.jade
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#auto-update
.btn-group.pull-right
a.btn.btn-primary(data-hook='cancel') Not now
a.btn.btn-primary(data-hook='confirm') Yes please
a.btn.btn-primary(data-hook='cancel', href='#') Not now
a.btn.btn-primary(data-hook='confirm', href='#') Yes please

p A newer version of Compass is now available! Would you like to install it and restart Compass?
3 changes: 2 additions & 1 deletion src/auto-update/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ var NotificationUpdateAvailable = View.extend({
}
});
},
cancel: function() {
cancel: function(evt) {
evt.preventDefault();
this.visible = false;
return false;
},
Expand Down