-
Notifications
You must be signed in to change notification settings - Fork 233
COMPASS-226 hiding decimal128 option if server < 3.4 #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Wrapped semvar call in a try/catch so test case doesn't complain with empty serverVersion. |
@KeyboardTsundoku It looks like the tests need to be updated for the new
|
@KeyboardTsundoku Also looks like merge conflicts, please rebase, thanks. |
2da946a
to
c262157
Compare
@pzrq should be fixed now |
👍 LGTM merged thanks @KeyboardTsundoku Minor nitpick is an integration unit test for the different server versions would have been nice, but we aren't enforcing tests on all changes yet from Thomas' Compass Q&A (QA) email. |
* COMPASS-226 added string comparison to server version to determine decimal hiding * COMPASS-226 commented out debug statement * COMPASS-226 testing for travis issues * COMPASS-226 put server version info in validation store * COMPASS-226 semvar is struggling with chai tests * COMPASS-226 slightly cleaner implementation * COMPASS-226 removed hanging .isRequired in props that add warnings in tests * Revert unnecessary SortableTable change See e71d665 * Clean up comments
No description provided.