Skip to content

Conversation

Sean-Oh
Copy link
Contributor

@Sean-Oh Sean-Oh commented Nov 8, 2016

Added fixed height and ability to scroll within dropdown.

cc: @fredtruman

@fredtruman
Copy link
Contributor

fredtruman commented Nov 9, 2016

I'm able to both scroll internally in the [TYPE] dropdown to view all options, and if I shrink the vertical height of the page I'm also able to scroll the entire view to see the entirety of the dropdown. so LGTM 👍

screenshot 2016-11-09 09 46 54

We should, however, discuss and address the larger inconsistencies in markup and styles for the different collection-level views as a separate item too.

@imlucas imlucas merged commit a78d688 into master Nov 10, 2016
@imlucas imlucas deleted the COMPASS-212-Dropdown-Overflow branch November 10, 2016 21:26
imlucas pushed a commit that referenced this pull request Nov 10, 2016
@imlucas
Copy link
Contributor

imlucas commented Nov 10, 2016

Backported to 1.5-releases

@imlucas imlucas self-assigned this Nov 14, 2016
@imlucas imlucas added this to the 1.5 milestone Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants