Skip to content

Conversation

Sean-Oh
Copy link
Contributor

@Sean-Oh Sean-Oh commented Nov 10, 2016

@fredtruman
Copy link
Contributor

👍 Overall LGTM for the moment. A couple notes though:

  • I think ideally the "rule builder" and "json" view switchers on the document validation tab would also stick, i.e. not scroll with the content below, but understand that's probably not possible at the moment with the way the page is constructed.
  • I imagine this issue will get slightly more complicated once we remove the query bar from the indexes and doc validation tabs, move the [insert] button to its own .action-bar row, etc. which cause a variable header height across collection views.

@Sean-Oh
Copy link
Contributor Author

Sean-Oh commented Nov 10, 2016

  • I think we could make the rule builder / json view switchers fixed as well. I can look take a look at this in another PR.
  • Once we remove the query bar, we can have two margin-top values dependent on the varying height of the header. We would just append them accordingly.

@imlucas imlucas changed the title COMPASS 298: Make all collection headers fixed position COMPASS-298: Make all collection headers fixed position Nov 10, 2016
@imlucas imlucas merged commit c75936a into master Nov 10, 2016
@imlucas imlucas deleted the COMPASS-298-Header-No-Scroll branch November 10, 2016 21:25
imlucas pushed a commit that referenced this pull request Nov 10, 2016
@imlucas
Copy link
Contributor

imlucas commented Nov 10, 2016

Backported to 1.5-releases

@imlucas imlucas self-assigned this Nov 14, 2016
@imlucas imlucas added this to the 1.5 milestone Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants