feat(compass): update close window hotkey to be cmd+shift+w to avoid conflict with close tab cmd+w COMPASS-7301 #5812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…conflict with close tab cmd+w COMPASS-7301
paula-stacho
approved these changes
May 14, 2024
|
@paula-stacho Yup! We'll update the https://www.mongodb.com/docs/compass/current/keyboard-shortcuts/ page. When closing this ticket I'll be marking the |
Anemy
deleted the
update-close-window-hotkey-to-not-conflict-with-close-tab
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-7301
The issue reported in the ticket is that the code mirror captures the
Cmd+w, which makes the close tab hotkey not run, however the close window electron hotkey still runs. This can be frustrating when there's something happening in other tabs. This pr mitigates the issue by updating close window to beCmd+Shift+w.