Skip to content

COMPASS-134: Use uuids for document list keys. #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2016
Merged

COMPASS-134: Use uuids for document list keys. #583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/internal-packages/crud/lib/component/document-list.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
const _ = require('lodash');
const React = require('react');
const uuid = require('node-uuid');
const app = require('ampersand-app');
const Action = require('hadron-action');
const ObjectID = require('bson').ObjectID;
Expand Down Expand Up @@ -192,12 +193,10 @@ class DocumentList extends React.Component {
/**
* Get the key for a doc.
*
* @param {Document} doc - The document.
*
* @returns {String} The unique key.
*/
_key(doc) {
return `${NamespaceStore.ns}_${JSON.stringify(doc._id)}`;
_key() {
return uuid.v4();
}

/**
Expand All @@ -223,7 +222,7 @@ class DocumentList extends React.Component {
renderDocuments(docs) {
return _.map(docs, (doc) => {
return (
<li className="document-list-item" key={this._key(doc)}>
<li className="document-list-item" key={this._key()}>
<Document doc={doc} key={this._key(doc)} editable={this.CollectionStore.isWritable()} />
</li>
);
Expand Down