COMPASS-287 distinct numeric types #584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rueckstiess
force-pushed
the
COMPASS-287-distinct-numeric-types
branch
from
6dbc18d to
575bd97
Compare
|
lgtm |
imlucas
added
backport:unknown
backport:maybe
and removed
ready for review
backport:unknown
labels
|
@imlucas If this is backportable without merge conflicts, let's do it. |
pzrq
pushed a commit
that referenced
this pull request
Nov 15, 2016
* COMPASS-287 upgrade old language-model to pegjs * fix bar selection rounding bug for negative, very large numbers and 0. * don’t promote values. * allow dotted field names and fix type switching bug * remove debug statements. * handle number ranges correctly for unpromoted bson types * fix query building for negative long values.
|
Backported in 87ac280 Resolved one package.json conflict by backporting #568 (COMPASS-224), resolved the other by not taking |
This was referenced Nov 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a number of updates to external modules:
mongodb-language-model@1.0.2 now using the pegjs implementation for richer feature support and faster query verification.
collection-sample@1.3.0 now supporting
promoteValuesoption, which can be set tofalseto retain the original BSON types for numeric values (Decimal128, Long, Double, Int32)mongodb-schema@6.0.2 update now supports
promoteValuesin the command line tool (no changes required for Compass though)detect-coordinates@0.2.0 can now recognise coordinates in both promoted and unpromoted form (i.e. looking for
Number,Int32orDoubletype inside coordinates array).mongodb-data-service@2.1.1 includes the new collection-sample changes and passes through the
promoteValuesoption.extended-json@1.8.0 adds support for $numberDecimal / Decimal128, which is required to build queries and document validation rules with Decimal.
All of these are updated for this PR.
Further changes:
Int32,Double,Long,Decimal128../src/app/models/editable-query.js, no longer needed. Query is now a pure javascript object.{price: {$gt: {$numberDecimal: "12.99"}}}.src/internal-packages/query/lib/util/index.jswhere determining if a minichart histogram bar is selected or not had a bug for negative values.