Skip to content

COMPASS-324: Document View not updating after query build via Schema #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2016
Merged

COMPASS-324: Document View not updating after query build via Schema #602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c2704e
COMPASS-324 added a count comparison of states in document-list shoul…
Nov 17, 2016
a04a3d5
COMPASS-324 included equality comparison between returned docs
Nov 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/internal-packages/crud/lib/component/document-list.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const InsertDocumentStore = require('../store/insert-document-store');
const InsertDocumentDialog = require('./insert-document-dialog');
const Actions = require('../actions');

// const debug = require('debug')('mongodb-compass:crud');
// const debug = require('debug')('mongodb-compass:crud:component');

/* eslint no-return-assign:0 */

Expand Down Expand Up @@ -66,10 +66,17 @@ class DocumentList extends React.Component {
* @returns {Boolean} If the component should update.
*/
shouldComponentUpdate(nextProps, nextState) {
return (nextState.docs.length !== this.state.docs.length) ||
(nextState.nextSkip !== this.state.nextSkip) ||
(nextState.loadedCount !== this.state.loadedCount) ||
(nextState.namespace !== this.state.namespace);
// compare the states if they're different update component
if ((nextState.docs.length !== this.state.docs.length)
|| (nextState.nextSkip !== this.state.nextSkip)
|| (nextState.loadedCount !== this.state.loadedCount)
|| (nextState.namespace !== this.state.namespace)
|| (nextState.count !== this.state.count)) {
return true;
}

// at this point compare the documents themselves and update if not different
return !_.isEqual(nextState.docs, this.state.docs);
}

/**
Expand Down
2 changes: 2 additions & 0 deletions src/internal-packages/crud/lib/store/reset-document-list-store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ const toNS = require('mongodb-ns');

// const debug = require('debug')('mongodb-compass:crud');

// const debug = require('debug')('mongodb-compass:crud:store');

/**
* The default read preference.
*/
Expand Down