Skip to content

Revert "fix(build): use an older ffmpeg version when packaging (#6070)" #6139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Revert "fix(build): use an older ffmpeg version when packaging (#6070)" #6139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions packages/hadron-build/lib/target.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,14 +196,7 @@ class Target {
arch: this.arch,
electronVersion: this.electronVersion,
sign: null,
afterExtract: [(buildPath, electronVersion, platform, arch, done) => {
// TODO(https://github.com/electron/electron/issues/43076): electron
// releases are pointing to a wrong version of ffmpeg codecs right now
// (platform mismatch), there is a fix in progress and we should switch
// asap when it's available, for now just use the ffmpeg from an older
// version
ffmpegAfterExtract(buildPath, '29.4.3', platform, arch, done)
}]
afterExtract: [ffmpegAfterExtract]
};

validateBuildConfig(this.platform, this.pkg.config.hadron.build[this.platform]);
Expand Down