Skip to content

COMPASS-291 explain only executes on apply press, otherwise remains z… #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 22, 2016
Merged

COMPASS-291 explain only executes on apply press, otherwise remains z… #614

merged 3 commits into from
Nov 22, 2016

Conversation

satyasinha
Copy link

…ero state

@satyasinha satyasinha force-pushed the COMPASS-291-Prevent-Auto-Explain branch from 5a18f84 to 0b6e800 Compare November 22, 2016 03:49
@rueckstiess
Copy link
Contributor

The behavior is now:

  • Explain is not executed by default.
  • Once the user presses Apply (on any tab), we also run an explain.
  • Clicking reset does not trigger another explain.

LGTM.

@rueckstiess rueckstiess merged commit c1ea8fe into master Nov 22, 2016
rueckstiess pushed a commit that referenced this pull request Nov 22, 2016
COMPASS-291 explain only executes on apply press, otherwise remains z… (
6f9bf6c 
#614)

* COMPASS-291 explain only executes on apply press, otherwise remains zero state

* defined debug

* COMPASS-291 added a status to query store, apply and reset

# Conflicts:
#	src/internal-packages/explain/lib/components/compass-explain.jsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport:done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@satyasinha @rueckstiess