Skip to content

feat(editor, query-bar): on query history autocomplete move cursor to end of content, small ux updates #6199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2024
Merged

feat(editor, query-bar): on query history autocomplete move cursor to end of content, small ux updates #6199

merged 1 commit into from
Sep 5, 2024

Conversation

Anemy
Copy link
Member

@Anemy Anemy commented Sep 4, 2024 •
edited
Loading

Couple smaller changes in here:

  1. When selecting a query history item from the autocomplete, we automatically move the cursor to the end of the editor.
  2. Don't provide the autocompletion for a query history item if it matches what's typed.
  3. Auto complete option info height reduced:
before after
Screenshot 2024-09-04 at 12 49 12 PM Screenshot 2024-09-04 at 1 07 12 PM

@github-actions github-actions bot added the feat label Sep 4, 2024
@Anemy Anemy merged commit 7d60fbd into main Sep 5, 2024
28 of 29 checks passed
@Anemy Anemy deleted the autocomplete-query-history-ux branch September 5, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lerouxb lerouxb lerouxb approved these changes

Assignees

No one assigned

Labels

feat release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Anemy @lerouxb