COMPASS-315: Don't auto-cast numeric types #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
added
backport:needed
ready for review
work in progress
and removed
work in progress
labels
durran
added a commit
that referenced
this pull request
Nov 23, 2016
durran
added a commit
that referenced
this pull request
Nov 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numeric values are no longer auto-cast to their smallest corresponding numeric value. This also changes the style stlightly on numerics to be different shades of green instead of all the same green. I experimented with putting the actual types around the numbers in the view, for example
Int32(12)but it became way too cluttered.