Compass 397 indexes usage #629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyasinha
force-pushed
the
COMPASS-397-Indexes-Usage
branch
from
6fcc222 to
b0645ec
Compare
|
While the actual task of this ticket is completed, test itself is not as complete as I would like. I'm struggling to write a functional test that can create an index via the create index modal and then observe it in the indexes tab. Any help on this would be great! |
rueckstiess
force-pushed
the
COMPASS-397-Indexes-Usage
branch
from
46296a0 to
9796753
Compare
|
I also rebased it to current master. @KeyboardTsundoku Could you review and test my changes? |
|
LGTM |
rueckstiess
pushed a commit
that referenced
this pull request
Nov 25, 2016
* replaced 'NA' with '0' * COMPASS-397 added some test cases around indexes * Only show N/A when $indexStats not available, otherwise 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.