COMPASS-340 privacy modal connect #632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rueckstiess
force-pushed
the
COMPASS-340-privacy-modal-connect
branch
from
7df2d3e to
b0b4205
Compare
satyasinha
force-pushed
the
COMPASS-340-privacy-modal-connect
branch
from
b0b4205 to
a7b0426
Compare
|
LGTM |
rueckstiess
added a commit
that referenced
this pull request
Nov 28, 2016
* COMPASS-340 move tour and privacy modals to ./src/app/index.js * fix bug where mixpanel is being used (currently disabled) * fix functional tests with tour/optin on connect screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Tour and Privacy Settings moved from
./src/app/home/index.jsto./src/app/index.js.Now the Tour and Privacy Settings open immediately when you start Compass for the first time, vs. only after you connected to an instance.
Functional tests adjusted to work with that change.
Also fixed a bug where we access mixpanel tracker even though it's disabled (commented out for now).