-
Notifications
You must be signed in to change notification settings - Fork 234
COMPASS 443: Standardise mongodb-runner CI #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build hangs forever: travis-ci/travis-ci#317 The reason I'm less font of the |
481043f
to
a935faf
Compare
Having now force-pushed a few times and seeing results like:
All considered, I suspect there's a race condition introduced here, but need more data from Travis to confirm statistically, and ideally without the |
It's concerning that we depend on the cached Travis infrastructure for our builds to pass. Either way the try race condition seems to only be reproducible with I'll leave this here over Sydney's weekend in case anyone finds it useful and close it on Monday if we have bigger fish to fry to get 1.5 out the door. |
Example of build failing excluding changes on this branch: EDIT: Via #631 |
0337d1a
to
8a40ca8
Compare
8a40ca8
to
17f1a45
Compare
mongodb-js/connection-model#138 NOTE: `npm run check && npm run test-unit` passes for me locally on macOS, but the functional tests `npm test ` still error with results: 177 passing (50s) 2 pending 10 failing 1) Compass #spectron when working with the application when working with collections when selecting a collection renders the sample collection in the title: Error: element (button[data-hook=start-button]) still not visible after 5000ms at elements("button[data-hook=start-button]") - isVisible.js:54:17 at isVisible("button[data-hook=start-button]") - waitForVisible.js:37:22 2) Compass #spectron when working with the application when working with collections when selecting a collection renders the schema tab: Error: An element could not be located on the page using the given search parameters. at element("li#SCHEMA") - click.js:12:17 at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55 3) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter the text in refine bar matches query: Error: Promise was rejected with the following reason: Error: An element could not be located on the page using the given search parameters ("input#refine_input"). at elements("input#refine_input") - getValue.js:18:17 at getValue("input#refine_input") - waitForValue.js:37:22 4) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter samples the matching documents: Error: element (div.sampling-message) still not visible after 15000ms at elements("div.sampling-message") - isVisible.js:54:17 at isVisible("div.sampling-message") - waitForVisible.js:37:22 5) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter updates the schema view: Error: An element could not be located on the page using the given search parameters ("li.bubble code.selectable"). at elements("li.bubble code.selectable") - getText.js:18:17 at getText("li.bubble code.selectable") - compass-functional.test.js:120:16 6) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter filters out non-matches from the document list: Error: An element could not be located on the page using the given search parameters. at element("li#DOCUMENTS") - click.js:12:17 at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55 7) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter includes documents that match the filter: Error: An element could not be located on the page using the given search parameters ("div.element-value-is-string"). at elements("div.element-value-is-string") - getText.js:18:17 at getText("div.element-value-is-string") - compass-functional.test.js:138:16 8) Compass #spectron when working with the application when working with collections when working in the documents tab when viewing documents renders the documents in the list: Error: An element could not be located on the page using the given search parameters. at element("li#DOCUMENTS") - click.js:12:17 at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55 9) Compass #spectron when working with the application when working with collections when working in the explain tab when viewing the explain tab renders the stages: Error: An element could not be located on the page using the given search parameters. at element("li#EXPLAIN_PLAN") - click.js:12:17 at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55 10) Compass #spectron when working with the application when working with collections when working in the indexes tab when viewing the indexes tab renders the indexes: Error: An element could not be located on the page using the given search parameters. at element("li#INDEXES") - click.js:12:17 at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55
Annoying as we can’t test multiple topologies, but probably a decent idea for Compass itself as we should delegate as much as possible to each public mongodb-js dependency. Note: Needed as otherwise TravisCI hangs for 10 minutes then kills the job even though it completes with exit code 0, i.e. successfully. e.g. https://travis-ci.com/10gen/compass/jobs/57691028
We can add it in when we decide we actually want to switch, as our private Travis seems to be a little under-powered at this time (build queues backing up).
17f1a45
to
7f36af9
Compare
* Standardise mongodb-runner CI mongodb-js/connection-model#138 NOTE: `npm run check && npm run test-unit` passes for me locally on macOS, but the functional tests `npm test ` still error with results: 177 passing (50s) 2 pending 10 failing 1) Compass #spectron when working with the application when working with collections when selecting a collection renders the sample collection in the title: Error: element (button[data-hook=start-button]) still not visible after 5000ms at elements("button[data-hook=start-button]") - isVisible.js:54:17 at isVisible("button[data-hook=start-button]") - waitForVisible.js:37:22 2) Compass #spectron when working with the application when working with collections when selecting a collection renders the schema tab: Error: An element could not be located on the page using the given search parameters. at element("li#SCHEMA") - click.js:12:17 at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55 3) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter the text in refine bar matches query: Error: Promise was rejected with the following reason: Error: An element could not be located on the page using the given search parameters ("input#refine_input"). at elements("input#refine_input") - getValue.js:18:17 at getValue("input#refine_input") - waitForValue.js:37:22 4) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter samples the matching documents: Error: element (div.sampling-message) still not visible after 15000ms at elements("div.sampling-message") - isVisible.js:54:17 at isVisible("div.sampling-message") - waitForVisible.js:37:22 5) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter updates the schema view: Error: An element could not be located on the page using the given search parameters ("li.bubble code.selectable"). at elements("li.bubble code.selectable") - getText.js:18:17 at getText("li.bubble code.selectable") - compass-functional.test.js:120:16 6) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter filters out non-matches from the document list: Error: An element could not be located on the page using the given search parameters. at element("li#DOCUMENTS") - click.js:12:17 at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55 7) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter includes documents that match the filter: Error: An element could not be located on the page using the given search parameters ("div.element-value-is-string"). at elements("div.element-value-is-string") - getText.js:18:17 at getText("div.element-value-is-string") - compass-functional.test.js:138:16 8) Compass #spectron when working with the application when working with collections when working in the documents tab when viewing documents renders the documents in the list: Error: An element could not be located on the page using the given search parameters. at element("li#DOCUMENTS") - click.js:12:17 at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55 9) Compass #spectron when working with the application when working with collections when working in the explain tab when viewing the explain tab renders the stages: Error: An element could not be located on the page using the given search parameters. at element("li#EXPLAIN_PLAN") - click.js:12:17 at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55 10) Compass #spectron when working with the application when working with collections when working in the indexes tab when viewing the indexes tab renders the indexes: Error: An element could not be located on the page using the given search parameters. at element("li#INDEXES") - click.js:12:17 at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55 * Go back to the full pretest and post test hooks Annoying as we can’t test multiple topologies, but probably a decent idea for Compass itself as we should delegate as much as possible to each public mongodb-js dependency. Note: Needed as otherwise TravisCI hangs for 10 minutes then kills the job even though it completes with exit code 0, i.e. successfully. e.g. https://travis-ci.com/10gen/compass/jobs/57691028 * Drop lts/boron We can add it in when we decide we actually want to switch, as our private Travis seems to be a little under-powered at this time (build queues backing up).
…n Modal sometimes cause page refresh to 1.5-releases (#758) * COMPASS-697: Backport COMPASS-666: Keyboard Enter on forms cause page refresh (#753) NOTE: Due to merge conflicts in our rapidly evolving functional test suite since creating the 1.5.x branch, ‘data-test-id’ values and the actual code fix has been backported and manually tested, but the functional test changes have not been back ported. * COMPASS 443: Standardise mongodb-runner CI (#633) * Standardise mongodb-runner CI mongodb-js/connection-model#138 NOTE: `npm run check && npm run test-unit` passes for me locally on macOS, but the functional tests `npm test ` still error with results: 177 passing (50s) 2 pending 10 failing 1) Compass #spectron when working with the application when working with collections when selecting a collection renders the sample collection in the title: Error: element (button[data-hook=start-button]) still not visible after 5000ms at elements("button[data-hook=start-button]") - isVisible.js:54:17 at isVisible("button[data-hook=start-button]") - waitForVisible.js:37:22 2) Compass #spectron when working with the application when working with collections when selecting a collection renders the schema tab: Error: An element could not be located on the page using the given search parameters. at element("li#SCHEMA") - click.js:12:17 at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55 3) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter the text in refine bar matches query: Error: Promise was rejected with the following reason: Error: An element could not be located on the page using the given search parameters ("input#refine_input"). at elements("input#refine_input") - getValue.js:18:17 at getValue("input#refine_input") - waitForValue.js:37:22 4) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter samples the matching documents: Error: element (div.sampling-message) still not visible after 15000ms at elements("div.sampling-message") - isVisible.js:54:17 at isVisible("div.sampling-message") - waitForVisible.js:37:22 5) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter updates the schema view: Error: An element could not be located on the page using the given search parameters ("li.bubble code.selectable"). at elements("li.bubble code.selectable") - getText.js:18:17 at getText("li.bubble code.selectable") - compass-functional.test.js:120:16 6) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter filters out non-matches from the document list: Error: An element could not be located on the page using the given search parameters. at element("li#DOCUMENTS") - click.js:12:17 at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55 7) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter includes documents that match the filter: Error: An element could not be located on the page using the given search parameters ("div.element-value-is-string"). at elements("div.element-value-is-string") - getText.js:18:17 at getText("div.element-value-is-string") - compass-functional.test.js:138:16 8) Compass #spectron when working with the application when working with collections when working in the documents tab when viewing documents renders the documents in the list: Error: An element could not be located on the page using the given search parameters. at element("li#DOCUMENTS") - click.js:12:17 at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55 9) Compass #spectron when working with the application when working with collections when working in the explain tab when viewing the explain tab renders the stages: Error: An element could not be located on the page using the given search parameters. at element("li#EXPLAIN_PLAN") - click.js:12:17 at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55 10) Compass #spectron when working with the application when working with collections when working in the indexes tab when viewing the indexes tab renders the indexes: Error: An element could not be located on the page using the given search parameters. at element("li#INDEXES") - click.js:12:17 at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55 * Go back to the full pretest and post test hooks Annoying as we can’t test multiple topologies, but probably a decent idea for Compass itself as we should delegate as much as possible to each public mongodb-js dependency. Note: Needed as otherwise TravisCI hangs for 10 minutes then kills the job even though it completes with exit code 0, i.e. successfully. e.g. https://travis-ci.com/10gen/compass/jobs/57691028 * Drop lts/boron We can add it in when we decide we actually want to switch, as our private Travis seems to be a little under-powered at this time (build queues backing up). * Standardise on no space It’s that way on master, just too lazy to mine git log to cherry-pick the change that did it somewhere between 1.5 and 1.7, to pass code review comments. #758 * Drop data-test-ids we do not need on 1.5-releases
See also mongodb-js/connection-model#138
NOTE:
npm run check && npm run test-unit
passes for me locally on macOS, but the functional testsnpm test
still error with results:177 passing (50s)
2 pending
10 failing
Compass #spectron when working with the application when working with collections when selecting a collection renders the sample collection in the title:
Error: element (button[data-hook=start-button]) still not visible after 5000ms
at elements("button[data-hook=start-button]") - isVisible.js:54:17
at isVisible("button[data-hook=start-button]") - waitForVisible.js:37:22
Compass #spectron when working with the application when working with collections when selecting a collection renders the schema tab:
Error: An element could not be located on the page using the given search parameters.
at element("li#SCHEMA") - click.js:12:17
at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55
Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter the text in refine bar matches query:
Error: Promise was rejected with the following reason: Error: An element could not be located on the page using the given search parameters ("input#refine_input").
at elements("input#refine_input") - getValue.js:18:17
at getValue("input#refine_input") - waitForValue.js:37:22
Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter samples the matching documents:
Error: element (div.sampling-message) still not visible after 15000ms
at elements("div.sampling-message") - isVisible.js:54:17
at isVisible("div.sampling-message") - waitForVisible.js:37:22
Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter updates the schema view:
Error: An element could not be located on the page using the given search parameters ("li.bubble code.selectable").
at elements("li.bubble code.selectable") - getText.js:18:17
at getText("li.bubble code.selectable") - compass-functional.test.js:120:16
Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter filters out non-matches from the document list:
Error: An element could not be located on the page using the given search parameters.
at element("li#DOCUMENTS") - click.js:12:17
at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55
Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter includes documents that match the filter:
Error: An element could not be located on the page using the given search parameters ("div.element-value-is-string").
at elements("div.element-value-is-string") - getText.js:18:17
at getText("div.element-value-is-string") - compass-functional.test.js:138:16
Compass #spectron when working with the application when working with collections when working in the documents tab when viewing documents renders the documents in the list:
Error: An element could not be located on the page using the given search parameters.
at element("li#DOCUMENTS") - click.js:12:17
at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55
Compass #spectron when working with the application when working with collections when working in the explain tab when viewing the explain tab renders the stages:
Error: An element could not be located on the page using the given search parameters.
at element("li#EXPLAIN_PLAN") - click.js:12:17
at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55
Compass #spectron when working with the application when working with collections when working in the indexes tab when viewing the indexes tab renders the indexes:
Error: An element could not be located on the page using the given search parameters.
at element("li#INDEXES") - click.js:12:17
at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55