Skip to content

Conversation

pzrq
Copy link
Contributor

@pzrq pzrq commented Nov 25, 2016

See also mongodb-js/connection-model#138

NOTE: npm run check && npm run test-unit passes for me locally on macOS, but the functional tests npm test still error with results:

177 passing (50s)
2 pending
10 failing

  1. Compass #spectron when working with the application when working with collections when selecting a collection renders the sample collection in the title:
    Error: element (button[data-hook=start-button]) still not visible after 5000ms
    at elements("button[data-hook=start-button]") - isVisible.js:54:17
    at isVisible("button[data-hook=start-button]") - waitForVisible.js:37:22

  2. Compass #spectron when working with the application when working with collections when selecting a collection renders the schema tab:
    Error: An element could not be located on the page using the given search parameters.
    at element("li#SCHEMA") - click.js:12:17
    at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55

  3. Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter the text in refine bar matches query:
    Error: Promise was rejected with the following reason: Error: An element could not be located on the page using the given search parameters ("input#refine_input").
    at elements("input#refine_input") - getValue.js:18:17
    at getValue("input#refine_input") - waitForValue.js:37:22

  4. Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter samples the matching documents:
    Error: element (div.sampling-message) still not visible after 15000ms
    at elements("div.sampling-message") - isVisible.js:54:17
    at isVisible("div.sampling-message") - waitForVisible.js:37:22

  5. Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter updates the schema view:
    Error: An element could not be located on the page using the given search parameters ("li.bubble code.selectable").
    at elements("li.bubble code.selectable") - getText.js:18:17
    at getText("li.bubble code.selectable") - compass-functional.test.js:120:16

  6. Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter filters out non-matches from the document list:
    Error: An element could not be located on the page using the given search parameters.
    at element("li#DOCUMENTS") - click.js:12:17
    at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55

  7. Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter includes documents that match the filter:
    Error: An element could not be located on the page using the given search parameters ("div.element-value-is-string").
    at elements("div.element-value-is-string") - getText.js:18:17
    at getText("div.element-value-is-string") - compass-functional.test.js:138:16

  8. Compass #spectron when working with the application when working with collections when working in the documents tab when viewing documents renders the documents in the list:
    Error: An element could not be located on the page using the given search parameters.
    at element("li#DOCUMENTS") - click.js:12:17
    at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55

  9. Compass #spectron when working with the application when working with collections when working in the explain tab when viewing the explain tab renders the stages:
    Error: An element could not be located on the page using the given search parameters.
    at element("li#EXPLAIN_PLAN") - click.js:12:17
    at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55

  10. Compass #spectron when working with the application when working with collections when working in the indexes tab when viewing the indexes tab renders the indexes:
    Error: An element could not be located on the page using the given search parameters.
    at element("li#INDEXES") - click.js:12:17
    at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55

@pzrq pzrq changed the title Standardise mongodb-runner CI COMPASS 443: Standardise mongodb-runner CI Nov 25, 2016
@pzrq
Copy link
Contributor Author

pzrq commented Nov 25, 2016

Build hangs forever: travis-ci/travis-ci#317

The reason I'm less font of the pretest and posttest hooks for configuration is AFAICT we couldn't test multiple distinct topologies (i.e. standalone, replica set, cluster), something which considering the number of bugs on secondaries we've just fixed would be really nice to have.

@pzrq pzrq force-pushed the travis-mongodb-runner branch 3 times, most recently from 481043f to a935faf Compare November 25, 2016 06:38
@pzrq
Copy link
Contributor Author

pzrq commented Nov 25, 2016

Having now force-pushed a few times and seeing results like:
screen shot 2016-11-25 at 5 59 03 pm

  1 failing
  1) Compass #spectron when working with the application when working with collections when working in the indexes tab when viewing the indexes tab try empty create index:
     Error: An element could not be located on the page using the given search parameters (".modal-status-error-message").
      at elements(".modal-status-error-message") - getText.js:18:17
      at submit("0.7060162656529185-39") - submitForm.js:20:22

screen shot 2016-11-25 at 5 43 45 pm

All considered, I suspect there's a race condition introduced here, but need more data from Travis to confirm statistically, and ideally without the sudo: required change.

@pzrq
Copy link
Contributor Author

pzrq commented Nov 25, 2016

screen shot 2016-11-25 at 6 28 36 pm

It's concerning that we depend on the cached Travis infrastructure for our builds to pass. Either way the try race condition seems to only be reproducible with sudo: required, so what's more likely to be going on is a semver accident somewhere like 2123fc4

I'll leave this here over Sydney's weekend in case anyone finds it useful and close it on Monday if we have bigger fish to fry to get 1.5 out the door.

@pzrq
Copy link
Contributor Author

pzrq commented Nov 28, 2016

Example of build failing excluding changes on this branch:
https://travis-ci.com/10gen/compass/builds/35616231

EDIT: Via #631

@pzrq pzrq force-pushed the travis-mongodb-runner branch 3 times, most recently from 0337d1a to 8a40ca8 Compare November 28, 2016 03:56
@pzrq pzrq force-pushed the travis-mongodb-runner branch from 8a40ca8 to 17f1a45 Compare November 29, 2016 22:41
pzrq added 3 commits November 30, 2016 11:42
mongodb-js/connection-model#138

NOTE: `npm run check && npm run test-unit` passes for me locally on macOS, but the functional tests `npm test ` still error with results:

  177 passing (50s)
  2 pending
  10 failing

  1) Compass #spectron when working with the application when working with collections when selecting a collection renders the sample collection in the title:
     Error: element (button[data-hook=start-button]) still not visible after 5000ms
      at elements("button[data-hook=start-button]") - isVisible.js:54:17
      at isVisible("button[data-hook=start-button]") - waitForVisible.js:37:22

  2) Compass #spectron when working with the application when working with collections when selecting a collection renders the schema tab:
     Error: An element could not be located on the page using the given search parameters.
      at element("li#SCHEMA") - click.js:12:17
      at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55

  3) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter the text in refine bar matches query:
     Error: Promise was rejected with the following reason: Error: An element could not be located on the page using the given search parameters ("input#refine_input").
      at elements("input#refine_input") - getValue.js:18:17
      at getValue("input#refine_input") - waitForValue.js:37:22

  4) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter samples the matching documents:
     Error: element (div.sampling-message) still not visible after 15000ms
      at elements("div.sampling-message") - isVisible.js:54:17
      at isVisible("div.sampling-message") - waitForVisible.js:37:22

  5) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter updates the schema view:
     Error: An element could not be located on the page using the given search parameters ("li.bubble code.selectable").
      at elements("li.bubble code.selectable") - getText.js:18:17
      at getText("li.bubble code.selectable") - compass-functional.test.js:120:16

  6) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter filters out non-matches from the document list:
     Error: An element could not be located on the page using the given search parameters.
      at element("li#DOCUMENTS") - click.js:12:17
      at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55

  7) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter includes documents that match the filter:
     Error: An element could not be located on the page using the given search parameters ("div.element-value-is-string").
      at elements("div.element-value-is-string") - getText.js:18:17
      at getText("div.element-value-is-string") - compass-functional.test.js:138:16

  8) Compass #spectron when working with the application when working with collections when working in the documents tab when viewing documents renders the documents in the list:
     Error: An element could not be located on the page using the given search parameters.
      at element("li#DOCUMENTS") - click.js:12:17
      at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55

  9) Compass #spectron when working with the application when working with collections when working in the explain tab when viewing the explain tab renders the stages:
     Error: An element could not be located on the page using the given search parameters.
      at element("li#EXPLAIN_PLAN") - click.js:12:17
      at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55

  10) Compass #spectron when working with the application when working with collections when working in the indexes tab when viewing the indexes tab renders the indexes:
     Error: An element could not be located on the page using the given search parameters.
      at element("li#INDEXES") - click.js:12:17
      at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55
Annoying as we can’t test multiple topologies, but probably a decent idea for Compass itself as we should delegate as much as possible to each public mongodb-js dependency.

Note: Needed as otherwise TravisCI hangs for 10 minutes then kills the job even though it completes with exit code 0, i.e. successfully.
e.g. https://travis-ci.com/10gen/compass/jobs/57691028
We can add it in when we decide we actually want to switch, as our private Travis seems to be a little under-powered at this time (build queues backing up).
@pzrq pzrq force-pushed the travis-mongodb-runner branch from 17f1a45 to 7f36af9 Compare November 30, 2016 00:43
@rueckstiess rueckstiess merged commit c22c5c8 into master Nov 30, 2016
@rueckstiess rueckstiess deleted the travis-mongodb-runner branch November 30, 2016 05:37
pzrq added a commit that referenced this pull request Jan 23, 2017
* Standardise mongodb-runner CI

mongodb-js/connection-model#138

NOTE: `npm run check && npm run test-unit` passes for me locally on macOS, but the functional tests `npm test ` still error with results:

  177 passing (50s)
  2 pending
  10 failing

  1) Compass #spectron when working with the application when working with collections when selecting a collection renders the sample collection in the title:
     Error: element (button[data-hook=start-button]) still not visible after 5000ms
      at elements("button[data-hook=start-button]") - isVisible.js:54:17
      at isVisible("button[data-hook=start-button]") - waitForVisible.js:37:22

  2) Compass #spectron when working with the application when working with collections when selecting a collection renders the schema tab:
     Error: An element could not be located on the page using the given search parameters.
      at element("li#SCHEMA") - click.js:12:17
      at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55

  3) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter the text in refine bar matches query:
     Error: Promise was rejected with the following reason: Error: An element could not be located on the page using the given search parameters ("input#refine_input").
      at elements("input#refine_input") - getValue.js:18:17
      at getValue("input#refine_input") - waitForValue.js:37:22

  4) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter samples the matching documents:
     Error: element (div.sampling-message) still not visible after 15000ms
      at elements("div.sampling-message") - isVisible.js:54:17
      at isVisible("div.sampling-message") - waitForVisible.js:37:22

  5) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter updates the schema view:
     Error: An element could not be located on the page using the given search parameters ("li.bubble code.selectable").
      at elements("li.bubble code.selectable") - getText.js:18:17
      at getText("li.bubble code.selectable") - compass-functional.test.js:120:16

  6) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter filters out non-matches from the document list:
     Error: An element could not be located on the page using the given search parameters.
      at element("li#DOCUMENTS") - click.js:12:17
      at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55

  7) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter includes documents that match the filter:
     Error: An element could not be located on the page using the given search parameters ("div.element-value-is-string").
      at elements("div.element-value-is-string") - getText.js:18:17
      at getText("div.element-value-is-string") - compass-functional.test.js:138:16

  8) Compass #spectron when working with the application when working with collections when working in the documents tab when viewing documents renders the documents in the list:
     Error: An element could not be located on the page using the given search parameters.
      at element("li#DOCUMENTS") - click.js:12:17
      at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55

  9) Compass #spectron when working with the application when working with collections when working in the explain tab when viewing the explain tab renders the stages:
     Error: An element could not be located on the page using the given search parameters.
      at element("li#EXPLAIN_PLAN") - click.js:12:17
      at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55

  10) Compass #spectron when working with the application when working with collections when working in the indexes tab when viewing the indexes tab renders the indexes:
     Error: An element could not be located on the page using the given search parameters.
      at element("li#INDEXES") - click.js:12:17
      at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55

* Go back to the full pretest and post test hooks

Annoying as we can’t test multiple topologies, but probably a decent idea for Compass itself as we should delegate as much as possible to each public mongodb-js dependency.

Note: Needed as otherwise TravisCI hangs for 10 minutes then kills the job even though it completes with exit code 0, i.e. successfully.
e.g. https://travis-ci.com/10gen/compass/jobs/57691028

* Drop lts/boron

We can add it in when we decide we actually want to switch, as our private Travis seems to be a little under-powered at this time (build queues backing up).
pzrq added a commit that referenced this pull request Jan 25, 2017
…n Modal sometimes cause page refresh to 1.5-releases (#758)

* COMPASS-697: Backport COMPASS-666: Keyboard Enter on forms cause page refresh (#753)

NOTE: Due to merge conflicts in our rapidly evolving functional test suite since creating the 1.5.x branch, ‘data-test-id’ values and the actual code fix has been backported and manually tested, but the functional test changes have not been back ported.

* COMPASS 443: Standardise mongodb-runner CI (#633)

* Standardise mongodb-runner CI

mongodb-js/connection-model#138

NOTE: `npm run check && npm run test-unit` passes for me locally on macOS, but the functional tests `npm test ` still error with results:

  177 passing (50s)
  2 pending
  10 failing

  1) Compass #spectron when working with the application when working with collections when selecting a collection renders the sample collection in the title:
     Error: element (button[data-hook=start-button]) still not visible after 5000ms
      at elements("button[data-hook=start-button]") - isVisible.js:54:17
      at isVisible("button[data-hook=start-button]") - waitForVisible.js:37:22

  2) Compass #spectron when working with the application when working with collections when selecting a collection renders the schema tab:
     Error: An element could not be located on the page using the given search parameters.
      at element("li#SCHEMA") - click.js:12:17
      at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55

  3) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter the text in refine bar matches query:
     Error: Promise was rejected with the following reason: Error: An element could not be located on the page using the given search parameters ("input#refine_input").
      at elements("input#refine_input") - getValue.js:18:17
      at getValue("input#refine_input") - waitForValue.js:37:22

  4) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter samples the matching documents:
     Error: element (div.sampling-message) still not visible after 15000ms
      at elements("div.sampling-message") - isVisible.js:54:17
      at isVisible("div.sampling-message") - waitForVisible.js:37:22

  5) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter updates the schema view:
     Error: An element could not be located on the page using the given search parameters ("li.bubble code.selectable").
      at elements("li.bubble code.selectable") - getText.js:18:17
      at getText("li.bubble code.selectable") - compass-functional.test.js:120:16

  6) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter filters out non-matches from the document list:
     Error: An element could not be located on the page using the given search parameters.
      at element("li#DOCUMENTS") - click.js:12:17
      at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55

  7) Compass #spectron when working with the application when working with collections when selecting a collection when applying a filter includes documents that match the filter:
     Error: An element could not be located on the page using the given search parameters ("div.element-value-is-string").
      at elements("div.element-value-is-string") - getText.js:18:17
      at getText("div.element-value-is-string") - compass-functional.test.js:138:16

  8) Compass #spectron when working with the application when working with collections when working in the documents tab when viewing documents renders the documents in the list:
     Error: An element could not be located on the page using the given search parameters.
      at element("li#DOCUMENTS") - click.js:12:17
      at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55

  9) Compass #spectron when working with the application when working with collections when working in the explain tab when viewing the explain tab renders the stages:
     Error: An element could not be located on the page using the given search parameters.
      at element("li#EXPLAIN_PLAN") - click.js:12:17
      at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55

  10) Compass #spectron when working with the application when working with collections when working in the indexes tab when viewing the indexes tab renders the indexes:
     Error: An element could not be located on the page using the given search parameters.
      at element("li#INDEXES") - click.js:12:17
      at elementIdDisplayed("0.9192226665154364-7") - isVisible.js:71:55

* Go back to the full pretest and post test hooks

Annoying as we can’t test multiple topologies, but probably a decent idea for Compass itself as we should delegate as much as possible to each public mongodb-js dependency.

Note: Needed as otherwise TravisCI hangs for 10 minutes then kills the job even though it completes with exit code 0, i.e. successfully.
e.g. https://travis-ci.com/10gen/compass/jobs/57691028

* Drop lts/boron

We can add it in when we decide we actually want to switch, as our private Travis seems to be a little under-powered at this time (build queues backing up).

* Standardise on no space

It’s that way on master, just too lazy to mine git log to cherry-pick the change that did it somewhere between 1.5 and 1.7, to pass code review comments.
#758

* Drop data-test-ids we do not need on 1.5-releases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants