COMPASS-334 active sidebar #637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rueckstiess
force-pushed
the
COMPASS-334-active-sidebar
branch
from
5272c85 to
3c9b93a
Compare
|
LGTM. |
|
@fredtruman For info we copied the updated sidebar styles as per your previous branch #635, but the default expanded state makes it harder to visually distinguish between a database and collection. Please let us know if you have any additional styling passes for 1.5, thanks. |
|
|
pzrq
pushed a commit
that referenced
this pull request
Nov 28, 2016
* COMPASS-334 active state for sidebar entries * make refresh icon white as well
|
Backported to 1.5-releases in 0ebd700 |
|
Thanks @pzrq . I'll see if I can address your points and will let you know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
active state (light gray background) for sidebar entries
Using this in favor of #635 because it's less complex to pass the active namespace down from the store than to create a callback chain to pass the information up the component tree.
I did not implement the "databases are collapsed by default" change from #635 because it breaks our automated tests and the behavior when searching for a collection is strange (it does not automatically expand the database of a matched collection, so it's invisible).