fix: global writes feature flag COMPAS-8524

[paula-stacho]

Description

Although this flag was created, it was never actually used. It was also defined in InternalUserPreferences instead of FeatureFlags. How did this work before? It was because atlasMetadata is missing for Electron Compass, so instead of the flag the isGlobalWritesSupported condition was never met:

compass/packages/compass-connections/src/utils/connection-supports.ts

Line 15 in 77c23bf

if (!atlasMetadata) {

Checklist

• New tests and/or benchmarks are included
• Documentation is changed or added
• I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

• Bugfix
• New feature
• Dependency update
• Misc

Open Questions

Dependents

Types of changes

• Backport Needed
• Patch (non-breaking change which fixes an issue)
• Minor (non-breaking change which adds functionality)
• Major (fix or feature that would cause existing functionality to change)

[mabaasit]

Why are we adding it as a feature flag on compass side? should it not be part of preferences and FF as part of MMS only?

[paula-stacho]

Good question. Tbh I am confused about the different types of preferences in compass and wanted to check this with @gribnoysup. I think Global Writes should be in the same group as Rolling Indexes, as both features are web only for now, but we might be adding them to desktop later.

[gribnoysup]

Yeah, so I think it's understandable that you can see these in either of those preferences groups, we don't really have a very clean separation there for case like this.

Saying that I think these map more to what we use the feature flag group of preferences for: they are temporary, will only be used for the initial rollout and then removed, we don't really need a dedicated preference for these features as their availability in UI has a stricter check against a cluster metadata that is not available in compass desktop (and at the point where it will be, they should start working without the feature flag required to toggle them)

This is different from something like saved queries feature where bringing it to the web will require more effort in making the system work universally across environments and so it's not something that is just temporarily disabled in the same sense as these that will be used for the rollout.

And to be clear this is a very loose definition that can be understandably argued against, we might consider introducing some new preferences group to remove the ambiguity, maybe something to think through a bit more, but probably doesn't need to block this particular change.

[mabaasit]

my only concern was if this is a ff on compass side, it will show up in settings-modal. but not a blocker.

[mabaasit]

thanks for catching this. I added it in InternalUserPreferences initially because FeatureFlags are specific to Compass and we want CompassWeb to pass this as a preference. And for MMS, its a feature flag, right?