chore(e2e): reuse the existing connection for the second test COMPASS-8790 #6626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
added
the
no-title-validation
mabaasit
approved these changes
Jan 16, 2025
addaleax
approved these changes
Jan 16, 2025
lerouxb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this was an oversight when I ported the tests to multiple connections.
await browser.connectWithConnectionString();will remove the connection if it already exists and add it back which is potentially open to race conditions since it is a bit "best effort" which would explain why it flakes.The original idea behind those tests is the first one starts up with a fresh new user dir and gets the first run experience with the welcome page and then the second one re-opens Compass with the connection already there and the first run experience already in the past.