Dedupe electron-prebuilt #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compass has a defined an electron-prebuilt version of `1.2.8`. `hadron-build` previously required `^1.4.12` and this would cause unexpected behavior only when developing Compass. In this case, we were compiling native add-on’s during `npm install` targeting the abi for `1.2.8` but they would suddenly start to fail as `hadron-build develop` would use `1.4.12` which is abi incompatible. ## Developers If you notice incompatible abi version messages in the devtools console or suddenly you can’t connect to mongodb instances using auth or via ssh tunnel, please run the below to dedupe the electron-prebuilt versions currently installed in your environment: ```bash npm install; npm dedupe; ```
pzrq
approved these changes
Dec 14, 2016
There was a problem hiding this comment.
Works for my SSH Tunnel / COMPASS-503 which is good, so I guess just waiting on Travis, thanks @imlucas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compass has a defined an electron-prebuilt version of
1.2.8.hadron-buildpreviously required^1.4.12and this would causeunexpected behavior only when developing Compass. In this case, we were compiling native add-on’s during
npm installtargeting the abi for1.2.8but they would suddenly start to fail ashadron-build developwould use
1.4.12which is abi incompatible.Developers
If you notice incompatible abi version messages in the devtools console
or suddenly you can’t connect to mongodb instances using auth or via
ssh tunnel, please run the below to dedupe the electron-prebuilt
versions currently installed in your environment:
Upstream
See mongodb-js/hadron-build#49