Skip to content

Conversation

Anemy
Copy link
Member

@Anemy Anemy commented May 13, 2025

A cleanup as this feature has been released now for some time, so we can remove this feature flag.

@Anemy Anemy added no release notes Fix or feature not for release notes no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) labels May 13, 2025
@mcasimir mcasimir requested a review from Copilot May 13, 2025 13:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Cleanup removal of the enableQueryHistoryAutocomplete feature flag and simplify the query editor to always use the history-enabled completer.

  • Removed the unused preference and import for createQueryAutocompleter
  • Simplified the OptionEditor component to always initialize createQueryWithHistoryAutocompleter
  • Deleted the flag definition and type from the preferences model

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/compass-query-bar/src/components/option-editor.tsx Dropped feature-flag checks, always use createQueryWithHistoryAutocompleter
packages/compass-preferences-model/src/feature-flags.ts Removed enableQueryHistoryAutocomplete from both type and definitions
Comments suppressed due to low confidence (2)

packages/compass-query-bar/src/components/option-editor.tsx:156

  • Add or update unit tests for OptionEditor to verify that it always uses createQueryWithHistoryAutocompleter now that the conditional branch is removed.
const completer = useMemo(() => {

packages/compass-preferences-model/src/feature-flags.ts:19

  • Ensure any external docs, migration guides, or schema definitions no longer reference enableQueryHistoryAutocomplete to prevent stale documentation.
enableQueryHistoryAutocomplete: boolean;

@Anemy Anemy merged commit 2120e88 into main May 14, 2025
51 of 55 checks passed
@Anemy Anemy deleted the remove-query-history-autocomplete-feature-flag branch May 14, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no release notes Fix or feature not for release notes no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants