Skip to content

Conversation

Anemy
Copy link
Member

@Anemy Anemy commented May 29, 2025

A small cleanup pr. There's still some enzyme in compass-crud, compass-serverstats, and databases-collections. Removed enzyme and updated the tests in compass-aggregations, compass-schema-validation, and compass-shell. Some of these tests could just be removed or could use a replacement, I was mostly looking to update them and keep things quick.

@Anemy Anemy added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label May 29, 2025
Copy link
Collaborator

@gribnoysup gribnoysup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Thanks for cleaning this up

it('renders an open chevron button', function () {
expect(wrapper.find(IconButton).exists()).to.equal(true);
expect(wrapper.find(Icon).prop('glyph')).to.equal('ChevronUp');
expect(screen.getByTestId('shell-toggle-button-open')).to.be.visible;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit for the future: role + label based selectors for cases like this are almost always a better and more meaningful choice for the test case

@Anemy Anemy merged commit c57efcd into main Jun 2, 2025
57 of 58 checks passed
@Anemy Anemy deleted the remove-enzyme branch June 2, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants