Skip to content

Conversation

mabaasit
Copy link
Collaborator

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@mabaasit mabaasit changed the title ci(tests): enable web tests for data modeling ci(tests): enable web tests for data modeling COMPASS-9470 Jun 19, 2025
context.atlasCloudSandboxCloudConfig ?? 'dev';

if (isTestingAtlasCloudSandbox(context)) {
if (isTestingAtlasCloudSandbox(context) || isTestingWeb()) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isTestingWeb applies to both, isTestingAtlasCloudSandbox is a subset

Suggested change
if (isTestingAtlasCloudSandbox(context) || isTestingWeb()) {
if (isTestingWeb()) {

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in 9302517

@mabaasit mabaasit marked this pull request as ready for review June 19, 2025 13:33
@mabaasit mabaasit requested a review from a team as a code owner June 19, 2025 13:33
@mabaasit mabaasit merged commit 32c815b into main Jun 19, 2025
58 checks passed
@mabaasit mabaasit deleted the enable-data-modeling-test-on-cloud branch June 19, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants