-
Notifications
You must be signed in to change notification settings - Fork 234
fix: move the debug for me button to the connection error toast COMPASS-9746 #7247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lerouxb
commented
Aug 28, 2025

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the connection error notification system by moving the debug functionality from a separate toast to the main connection error toast, consolidating the UI into a single notification.
Key changes include:
- Consolidating debug functionality into the main connection error toast
- Updating the toast layout to display connection name as title and error message as description
- Replacing separate debug toast with a debug button alongside the review button
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
packages/compass-web/src/entrypoint.spec.tsx | Updates test assertion to match new error message format |
packages/compass-e2e-tests/tests/connection.test.ts | Updates E2E tests for consolidated toast UI and re-enables AI assistant feature |
packages/compass-e2e-tests/helpers/selectors.ts | Adds new selector for connection error title element |
packages/compass-e2e-tests/helpers/commands/connect.ts | Updates error text retrieval to use correct selector |
packages/compass-connections/src/stores/connections-store-redux.ts | Refactors error handling to use single toast with both review and debug actions |
packages/compass-connections/src/stores/connections-store-redux.spec.tsx | Updates test expectation for debug functionality in main toast |
packages/compass-connections/src/components/connection-status-notifications.tsx | Major refactor of toast components to consolidate debug and review actions |
packages/compass-components/src/hooks/use-toast.tsx | Adds className property support to toast configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/compass-connections/src/components/connection-status-notifications.tsx
Outdated
Show resolved
Hide resolved
7672f12
to
1479cc2
Compare
'Given the error message below,' | ||
); | ||
}); | ||
if (!TEST_COMPASS_WEB) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.