Skip to content

Conversation

lerouxb
Copy link
Contributor

@lerouxb lerouxb commented Aug 28, 2025

Screenshot 2025-08-28 at 13 01 49

@Copilot Copilot AI review requested due to automatic review settings August 28, 2025 14:28
@lerouxb lerouxb added the feature flagged PRs labeled with this label will not be included in the release notes of the next release label Aug 28, 2025
@lerouxb lerouxb requested a review from a team as a code owner August 28, 2025 14:28
@github-actions github-actions bot added the fix label Aug 28, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the connection error notification system by moving the debug functionality from a separate toast to the main connection error toast, consolidating the UI into a single notification.

Key changes include:

  • Consolidating debug functionality into the main connection error toast
  • Updating the toast layout to display connection name as title and error message as description
  • Replacing separate debug toast with a debug button alongside the review button

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/compass-web/src/entrypoint.spec.tsx Updates test assertion to match new error message format
packages/compass-e2e-tests/tests/connection.test.ts Updates E2E tests for consolidated toast UI and re-enables AI assistant feature
packages/compass-e2e-tests/helpers/selectors.ts Adds new selector for connection error title element
packages/compass-e2e-tests/helpers/commands/connect.ts Updates error text retrieval to use correct selector
packages/compass-connections/src/stores/connections-store-redux.ts Refactors error handling to use single toast with both review and debug actions
packages/compass-connections/src/stores/connections-store-redux.spec.tsx Updates test expectation for debug functionality in main toast
packages/compass-connections/src/components/connection-status-notifications.tsx Major refactor of toast components to consolidate debug and review actions
packages/compass-components/src/hooks/use-toast.tsx Adds className property support to toast configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

'Given the error message below,'
);
});
if (!TEST_COMPASS_WEB) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is surprising, I'm enabling the ff locally and it seems to work just fine:

image

Why are we skipping those here? Do we have a ticket for re-enabling those?

Copy link
Contributor Author

@lerouxb lerouxb Aug 28, 2025

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lerouxb lerouxb merged commit 3508451 into main Aug 29, 2025
53 of 58 checks passed
@lerouxb lerouxb deleted the one-error-toast branch August 29, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature flagged PRs labeled with this label will not be included in the release notes of the next release fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants