Skip to content

chore(compass-assistant): apply patches to assistant styling COMPASS-9790 #7284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2025
Merged

chore(compass-assistant): apply patches to assistant styling COMPASS-9790 #7284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9654454
chore(compass-assistant): apply patches to assistant styling COMPASS-…
gagik Sep 4, 2025
509a4f5
chore: fix workspaces
gagik Sep 4, 2025
c28ff1d
chore: change width of inner container instead
gagik Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions packages/compass-assistant/src/assistant-chat.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,29 +71,36 @@ const assistantChatFixesStyles = css({
},
/** TODO(COMPASS-9751): We're adjusting styling of all the headers to a lower level than the default for chat, this should be updated in Leafygreen as well and removed from our end. */
'h1, h2, h3, h4, h5, h6': {
margin: 'unset',
fontFamily: fontFamilies.default,
margin: 'unset',
},
/** h4, h5, h6 -> body 1 styling */
'h4, h5, h6': {
fontSize: '13px',
lineHeight: '15px',
marginTop: '4px',
},
/** h1 -> h3 styling */
h1: {
fontSize: '24px',
lineHeight: '32px',
fontSize: '20px',
marginTop: '8px',
fontWeight: 'medium',
lineHeight: '22px',
},
/** h2 -> subtitle styling */
h2: {
color: '#001E2B',
fontWeight: 'semibold',
fontSize: '18px',
lineHeight: '20px',
marginTop: '8px',
},
/** h3 -> body 2 styling */
h3: {
fontSize: '16px',
fontWeight: 'semibold',
lineHeight: '18px',
marginTop: '4px',
},
});
const messageFeedFixesStyles = css({
Expand All @@ -102,6 +109,12 @@ const messageFeedFixesStyles = css({
overflowY: 'auto',
flex: 1,
padding: spacing[400],
gap: spacing[400],

// TODO(COMPASS-9751): We're setting the font weight to 600 here as the LG styling for the Assistant header isn't set
'& > div > div:has(svg[aria-label="Sparkle Icon"]) p': {
fontWeight: 600,
},
});
const chatWindowFixesStyles = css({
height: '100%',
Expand Down
2 changes: 1 addition & 1 deletion packages/compass-components/src/components/drawer/drawer/drawer.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ const getBaseStyles = ({ theme }: { theme: Theme }) => css`
all: unset;
background-color: ${color[theme].background.primary.default};
border: 1px solid ${color[theme].border.secondary.default};
width: 100%;
max-width: ${PANEL_WIDTH}px;
height: 100%;
overflow: hidden;
Expand Down Expand Up @@ -207,6 +206,7 @@ const getInnerOpenContainerStyles = css`
transition-duration: ${transitionDuration.slowest}ms;
transition-timing-function: linear;
opacity: 1;
width: ${PANEL_WIDTH}px;
`;

export const getInnerContainerStyles = ({
Expand Down
18 changes: 13 additions & 5 deletions packages/compass-workspaces/src/components/workspaces.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,12 @@ const workspacesContentStyles = css({
minHeight: 0,
});

const workspacesSectionStyles = css({
display: 'flex',
minWidth: '600px',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seemed like the min size after which things start to break

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-09-05 at 11 15 44

Let's merge this, but I'm starting a thread in the design channel just to have a conversation about what we expect here longer term.

width: '100%',
});

type CompassWorkspacesProps = {
tabs: WorkspaceTab[];
activeTab?: WorkspaceTab | null;
Expand Down Expand Up @@ -217,11 +223,13 @@ const CompassWorkspaces: React.FunctionComponent<CompassWorkspacesProps> = ({

<div className={workspacesContentStyles}>
<DrawerAnchor>
{activeTab && workspaceTabContent ? (
workspaceTabContent
) : (
<EmptyWorkspaceContent></EmptyWorkspaceContent>
)}
<div className={workspacesSectionStyles}>
{activeTab && workspaceTabContent ? (
workspaceTabContent
) : (
<EmptyWorkspaceContent></EmptyWorkspaceContent>
)}
</div>
</DrawerAnchor>
</div>
</div>
Expand Down
Loading