Skip to content

fix(scripts): consistently use caret version when updating dependencies both in package.json and in npm scripts #7319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2025
Merged

fix(scripts): consistently use caret version when updating dependencies both in package.json and in npm scripts #7319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions scripts/update-dependencies.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ function updateDependencies(packageJson, newVersions) {
if (packageJson[depType]) {
for (const packageName of Object.keys(packageJson[depType])) {
if (packageJson[depType][packageName] && newVersions[packageName]) {
packageJson[depType][packageName] = `^${newVersions[packageName]}`;
packageJson[depType][packageName] = newVersions[packageName];
}
}
}
Expand Down Expand Up @@ -122,9 +122,9 @@ function updateDependencies(packageJson, newVersions) {
function updateOverrides(overrides, newVersions, parent) {
for (const name of Object.keys(overrides ?? {})) {
if (typeof overrides[name] === 'string' && newVersions[name]) {
overrides[name] = `^${newVersions[name]}`;
overrides[name] = newVersions[name];
} else if (name === '.' && parent && newVersions[parent]) {
overrides[name] = `^${newVersions[name]}`;
overrides[name] = newVersions[name];
} else if (typeof overrides[name] === 'object') {
updateOverrides(overrides[name], newVersions, name);
}
Expand Down Expand Up @@ -205,7 +205,7 @@ async function main() {
return depToUpdate;
});

const newVersions = await withProgress(
let newVersions = await withProgress(
`Collecting version information for packages...`,
() => {
return Promise.all(
Expand All @@ -227,6 +227,13 @@ async function main() {
);
console.log();

newVersions = newVersions.map(([name, version]) => {
// When updating we always want to use version with a caret, this allows
// some flexibility for third parties that depend on compass deps to have
// some flexibility in transitive dependencies versions
return [name, `^${version}`];
});

const newVersionsObj = Object.fromEntries(newVersions);
let hasChanged;

Expand Down
Loading