COMPASS-394: Collapse sidebar by default #740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyasinha
changed the title
|
For the functional tests note that |
satyasinha
force-pushed
the
COMPASS-394-collapse-sidebar-by-default
branch
3 times, most recently
from
4847721 to
f890887
Compare
satyasinha
force-pushed
the
COMPASS-394-collapse-sidebar-by-default
branch
from
f890887 to
6646aac
Compare
|
So it turns out admin database is not available in some versions of mongodb (or similar) taking that into account should fix the functional tests. |
|
LGTM. |
|
For the blog:
|
|
Nice one @KeyboardTsundoku 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm seeing this odd error below on the functional tests (even though they all pass)
If someone could please check if it's happening on their system that would be great :)
(Edit: this error was happening on master for me and seems to be unrelated to this ticket)