Skip to content

Conversation

Sean-Oh
Copy link
Contributor

@Sean-Oh Sean-Oh commented Feb 17, 2017

In this PR, I:

  • Remove the strange blue outline on button + form focus / active states
  • Make sure all buttons are properly vertically centered
  • Fix some other issues that resulted from overlapping bootstrap source styles

cc: @KeyboardTsundoku @pzrq

@Sean-Oh Sean-Oh requested a review from fredtruman February 17, 2017 04:34
@fredtruman
Copy link
Contributor

fredtruman commented Feb 17, 2017

Would you mind adding screenshots of changes?

  • query bar focus fix
  • timeout on schema buttons
  • SSH identity file button
  • ?

@pzrq
Copy link
Contributor

pzrq commented Feb 17, 2017

@Sean-Oh Is there a reason the 10strap.less file is still present? Can we remove it if that was the original goal of COMPASS-722?

@Sean-Oh
Copy link
Contributor Author

Sean-Oh commented Feb 17, 2017

1. No outline on view switcher
screen shot 2017-02-17 at 5 36 21 pm
2. Vertically centered file upload button
screen shot 2017-02-17 at 5 11 39 pm
3. Timeout Buttons
screen shot 2017-02-17 at 5 58 30 pm

4. No outline on other buttons (like the refresh button) and on filter/query inputs

test

Note: The advanced query bar should have some sort of focus state, but this might tricky to do in pure CSS and warrants further investigation as a separate task.

Copy link
Contributor

@fredtruman fredtruman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind opening a ticket for the query bar focus state as a task? Otherwise, let's get this in and go from there! 👍

@pzrq
Copy link
Contributor

pzrq commented Feb 20, 2017

Thanks @Sean-Oh @fredtruman

Merging this, as this has an approval from @fredtruman and also resolves the following SSL Client and Server Validation buttons issue in COMPASS-759.

AFTER

fixed ssl buttons

BEFORE

ssl connect to host not centered on master 819a208e650ae2c9c365c83cb404ba02ab226d2e

@pzrq pzrq merged commit f454db7 into master Feb 20, 2017
@pzrq pzrq deleted the COMPASS-722-Button-Patch branch February 20, 2017 05:24
@Sean-Oh
Copy link
Contributor Author

Sean-Oh commented Feb 20, 2017

Great, thanks. Link to query bar ticket here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants