Skip to content

Conversation

satyasinha
Copy link

@satyasinha satyasinha commented Feb 28, 2017

This is an attempt to fix the bug brought on via COMPASS-791 where if user returns to the same collection they were after going to a database/instance level CRUD and Schema doesn't reload.

DO NOT CUT ANY BRANCHES with COMPASS-791 without this fix

EDIT: This is now using the naive implementation, where all namespace changes trigger a query changed store event, and the collection level stores change only if the namespace is a collection

@satyasinha satyasinha changed the title [WIP] COMPASS-791 Bug fix COMPASS-791 Bug fix Mar 1, 2017
@satyasinha satyasinha changed the title COMPASS-791 Bug fix COMPASS-831 Bug fix Mar 1, 2017
@satyasinha satyasinha changed the title COMPASS-831 Bug fix COMPASS-831 Bug fix for COMPASS-791 Mar 1, 2017
@durran durran self-requested a review March 1, 2017 09:36
@durran durran force-pushed the COMPASS-791-bug-fix branch from 19d3bc7 to f34aadf Compare March 1, 2017 11:26
@durran
Copy link
Member

durran commented Mar 1, 2017

I rebased against master and tested this locally - works for me. Waiting on build to merge unless there is anything else that needs to go in here.

@durran durran removed their request for review March 1, 2017 11:26
@durran durran force-pushed the COMPASS-791-bug-fix branch from f34aadf to 2ec9109 Compare March 1, 2017 15:38
@durran
Copy link
Member

durran commented Mar 1, 2017

This is currently failing the unit tests:

  1) ChartStoreIntegration queryCache after clicking apply the queryCache is populated:

      Uncaught AssertionError: expected {} to deeply equal { Object (project, sort, ...) }
      + expected - actual

      -{}
      +{
      +  "filter": {
      +    "foo": 1
      +  }
      +  "limit": 0
      +  "maxTimeMS": 10000
      +  "ns": "db.testing"
      +  "project": [null]
      +  "queryState": "apply"
      +  "skip": 0
      +  "sort": {
      +    "_id": 1
      +  }
      +}
      
      at Assertion.assertEqual (/Users/modetojoy/work/10gen/compass/node_modules/chai/lib/chai/core/assertions.js:485:19)
      at Assertion.ctx.(anonymous function) [as equal] (/Users/modetojoy/work/10gen/compass/node_modules/chai/lib/chai/utils/addMethod.js:41:25)
      at setTimeout (/Users/modetojoy/work/10gen/compass/test/renderer/chart.store.integration.test.js:64:39)

@satyasinha satyasinha force-pushed the COMPASS-791-bug-fix branch from 2ec9109 to fa32b66 Compare March 2, 2017 03:06
@satyasinha
Copy link
Author

My bad, I included the chart store as part of the fix but it doesn't need it at the moment.

@satyasinha satyasinha force-pushed the COMPASS-791-bug-fix branch from fa32b66 to ab768a5 Compare March 2, 2017 03:17
@satyasinha satyasinha force-pushed the COMPASS-791-bug-fix branch from ab768a5 to 51329cc Compare March 2, 2017 03:47
@satyasinha satyasinha merged commit 0a0e1ba into master Mar 2, 2017
@satyasinha satyasinha deleted the COMPASS-791-bug-fix branch March 2, 2017 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants