COMPASS-824 backport COMPASS-742 (allowDiskUse) #807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will allow 1.6 versions to connect to atlas free tier instances.
rueckstiess
changed the title
|
Restarting Travis as it looks like the underlying AWS S3 issues. |
|
The bad response code looked like mongodb-runner wasn't working, that appears to have been fixed in the last few minutes so going to retry these again:
EDIT: No, but for some reason I can EDIT EDIT: Sometimes as the push build has now passed! :S |
pzrq
approved these changes
Mar 1, 2017
There was a problem hiding this comment.
LGTM 👍
Just been waiting on Travis (for half the day).
I tested this locally and on my Atlas free tier and didn't find anything amiss, not even in Create Index where we still expected we might find issues.
Found it strange not having the nice shiny query bar and the sidebar DDL buttons / instance header changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this backport will allow 1.6 versions to connect to atlas free tier instances.
This PR is against the
1.6-releasesbranch directly. A cherry-pick from the original COMPASS-742 ticket was not possible because the actual bump of data-service was handled in COMPASS-809 already, so COMPASS-742 was a no-op in Compass itself.This backport explicitly bumps the version of data-service, which includes collection-sample@1.5.1 which is Atlas-free-tier-aware.