COMPASS-839 Backport COMPASS-830 SSL / Atlas explicitly to 1.6-releases #812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Drop clipboard override Blur one is still useful if the user types in *.mongodb.net manually. It duplicates a soon to be unnecessary check: mongodb-js/connection-model@0588d35 * ⬆️ mongodb-connection-model@6.4.2 npm i --upgrade mongodb-connection-model --save * ⬆️ mongodb-data-service@2.12.3 npm i --upgrade mongodb-data-service --save Needed to resolve COMPASS 830 as we'd like to bust any caches that may exist (node_modules), and also data-service depends on connection-model, for example it calls `connect()` from connection-model.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a separate local repo tracking 1.6-releases, I have checked:
npm installupgrades connection-modelI have not verified that the transitively determined connection-model of data-service gets upgraded when data-service is upgraded (as this SO doesn't work and I don't really want to play with shrinkwrap), but would be surprised if it was not.