INT-1403: better electron support #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The colors LGTM (look great, really). The code changes are such that this becomes a hard fork. Should we submit this upstream? How likely are these changes to be accepted? |
|
I'm pretty sure that the "routing" in the new |
imlucas
added a commit
to mongodb-js/compass
that referenced
this pull request
Jun 22, 2016
imlucas
added a commit
to mongodb-js/compass
that referenced
this pull request
Jun 22, 2016
kangas
pushed a commit
to mongodb-js/compass
that referenced
this pull request
Jun 22, 2016
See mongodb-js/debug#1 See mongodb-js/hadron-build#12 (cherry picked from commit 8c55343)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Colors and pretty formatting when running in an electron renderer process.
This change is