chore: take monorepoRoot into account in getPackagesInTopologicalOrder() #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Sep 4, 2023
| return { | ||
| name: packageJson.name, | ||
| location: packageJsonPath, | ||
| location: path.dirname(packageJsonLocation), |
There was a problem hiding this comment.
This was previously a filename and is now a directory name, just making sure that that is intentional?
There was a problem hiding this comment.
Kinda. We only ever used it as a dirname and by the time we return to the outside we just want a path to a directory. Let me clean that up so it is clearer.
addaleax
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while working on mongodb-js/mongosh#1621.
cwdis potentially something quite deep and different from monorepoRoot when runningnpm run evergreen-release bumpand then glob() ends up returning a blank array.