chore/MIG-6658 Add README.md and CONTRIBUTING.md #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchans
changed the title
|
Thanks @marian-derias, addressed those comments in c751a1e |
marian-derias
approved these changes
May 22, 2025
sahildmk
approved these changes
May 26, 2025
| Write commit messages that are straightforward, clear, and describe a single purpose. Similar to pull request naming, the format is something like the following: | ||
|
|
||
| ``` | ||
| <type>/<ticket-ID> <short description> |
There was a problem hiding this comment.
Do commit messages also need a type and ticket-ID? I guess this depends on the PR merge policy. If we do squash and merge, I don't think this is required, but if we're not squashing then this makes sense to me.
There was a problem hiding this comment.
Haven't decided on the merge policy yet, but I'll keep this in here for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External Links
Description