feature/MIG-6673 Expose handlers and other props to the diagram #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchans
commented
Apr 29, 2025
| onlyRenderVisibleElements={true} | ||
| edges={edges} | ||
| connectionLineComponent={ConnectionLine} | ||
| connectionMode={ConnectionMode.Loose} |
There was a problem hiding this comment.
These props are copied over from the Relational Migrator diagramming component. We can hard code it now as I see no reason to pass these in as a prop (yet)
lchans
commented
Apr 29, 2025
There was a problem hiding this comment.
Probably a preference thing but I think the nodes in the 'Basic Diagram' shouldn't be connectable so consumers get a sense of how the nodes are movable. Right now you can start to create edges between them but of course they're not created:
Screen.Recording.2025-04-30.at.10.13.04.am.mov
sahildmk
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External Links
Description