Skip to content

bugfix/MIG-6690 Fix border #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

bugfix/MIG-6690 Fix border #34

merged 1 commit into from
May 20, 2025

Conversation

lchans
Copy link
Collaborator

@lchans lchans commented May 20, 2025

External Links

Description

  • Within Relational Migrator, the negative padding and margin were causing issue, so this change adds this to the top, left, width and height variable instead
  • Adds some comments to the styling to give a better explanation to what is going on
  • Adds a test-id to the border

@lchans lchans requested review from sahildmk and marian-derias May 20, 2025 00:18
@lchans lchans marked this pull request as ready for review May 20, 2025 00:18
marian-derias
marian-derias approved these changes May 20, 2025
View reviewed changes
Copy link
Collaborator

@marian-derias marian-derias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments!

@lchans lchans merged commit c33ab76 into main May 20, 2025
1 check passed
@lchans lchans deleted the bugfix/MIG-6690-fix-preview branch May 20, 2025 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marian-derias marian-derias marian-derias approved these changes

@sahildmk sahildmk Awaiting requested review from sahildmk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lchans @marian-derias