Skip to content

Conversation

lchans
Copy link
Collaborator

@lchans lchans commented May 26, 2025

External Links

Description

  1. Changes the glyph alignment to be flex-start and not flex-end
  2. Allow consumers to specify their own glyph size, if necessary

πŸ“Έ Screenshots/Screencasts

Screenshot 2025-05-27 at 9 53 56β€―AM

@lchans lchans marked this pull request as ready for review May 26, 2025 23:57
Copy link
Collaborator

@marian-derias marian-derias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A side note that the "Disabled node" and "Disabled field" nodes are not overriding the hover behaviour, which makes them seem interactable. Should the disabled field automatically override hover? But that is unrelated to this PR.

Screen.Recording.2025-05-27.at.11.30.14.am.mov

@lchans
Copy link
Collaborator Author

lchans commented May 27, 2025

@marian-derias There's a hoverVariant that the user can supply themselves!

@lchans lchans merged commit a6fb560 into main May 27, 2025
1 check passed
@lchans lchans deleted the bugfix/MIG-6833-change-glyph-alignment branch May 27, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants