bugfix/MIG-6838 Fix styling of primary field #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marian-derias
approved these changes
May 27, 2025
sahildmk
approved these changes
May 27, 2025
adrianhhong
reviewed
May 28, 2025
| } else if (variant === 'primary' && glyph === 'key') { | ||
| return palette.blue.base; | ||
| } else { | ||
| return glyph === 'key' ? getAccent() : internalTheme.node.icon; |
There was a problem hiding this comment.
This line also has a check if the glyph is 'key'.
There was a problem hiding this comment.
If the user sets the variant as "primary" then only the key (And no other glyphs) will be blue. If there is no variant, the key defaults back to the accent color (Green for MongoDB, purple for Relational)
There was a problem hiding this comment.
Ah sorry I missed that, sleepy day for me
lchans
force-pushed
the
bugfix/MIG-6838-fix-styling-of-primary-field
branch
from
426b3dc to
67de2c2
Compare
adrianhhong
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External Links
Description
📸 Screenshots/Screencasts