bugfix/MIG-6835 Set title prop correctly and co-erce isConnectable value #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchans
force-pushed
the
bugfix/MIG-6835-fix-titles-and-hover-state
branch
from
c6734b7 to
20a4d3c
Compare
lchans
changed the title
lchans
changed the title
adrianhhong
approved these changes
May 28, 2025
marian-derias
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External Links
Description
Couple of changes in this PR:
titleprop on the node, so that the node title shows up when the user hovers over ittitleprop on the diagram, so when users hover over the diagram the title does not keep popping up (We never set this prop before in the Relational Migrator diagram)isConnectableprop to false if not provided; there were some instances where the crosshair would appear, even if not in connection mode.zIndextoz-index- The use ofzIndexwas throwing an invalid prop error