chore: always use whatwg-url #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives us consistency across environments when there are edge
cases (in particular, the browser URL parser handles URLs that
start with protocols very differently, e.g.
`new URL("bar://foo/baz").pathname === "//foo/baz"`).
mcasimir
approved these changes
Jul 6, 2021
mcasimir
reviewed
Jul 6, 2021
| abstract hostname: never; | ||
| abstract port: never; | ||
| abstract href: string; | ||
| abstract get host(): never; |
There was a problem hiding this comment.
what is the difference between the abstract property and the getter/setter?
There was a problem hiding this comment.
@mcasimir I don’t know why, but the TS definitions for whatwg-url use accessors, and the TS definitions for the global URL use properties. 🤷♀️
This was referenced Aug 6, 2021
chore(service-provider-core): parse authMechProps rather than applying regex
mongodb-js/mongosh#1051
Merged
|
Can you also create a follow up issue that tracks browser bugs so we know when we can stop rely on a heavy polyfill? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us consistency across environments when there are edge
cases (in particular, the browser URL parser handles URLs that
start with protocols very differently, e.g.
new URL("bar://foo/baz").pathname === "//foo/baz").