chore: improve invalid connection string message when scheme/protocol is invalid #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think having the errors here be descriptive will probably help users down the line. This makes it so we can remove this message in Compass: https://github.com/mongodb-js/compass/pull/2692/files#diff-ba79710b42fded58d9766f054a11ba5a3646e74b580689f2dcf8e18404594e2fL199
And VSCode: https://github.com/mongodb-js/vscode/blob/main/src/connectionController.ts#L250
Should we also mention the connection string being passed as we did previously?
Invalid schema, expected connection string to start with "mongodb://" or "mongodb+srv://"vs
Invalid connection string "totallynotamongodb://outerspace", expected uri to start with "mongodb://" or "mongodb+srv://"Any preference on error message?
MongoDB connection strings begin with "mongodb://" or "mongodb+srv://"vs
Invalid schema, expected connection string to start with "mongodb://" or "mongodb+srv://"