Skip to content
This repository was archived by the owner on Feb 4, 2022. It is now read-only.

fix(sspi): correct auth process for SSPI #369

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

mbroadst
Copy link
Member

The SSPI auth process should have been the same as GSSAPI, but
it instead initialized and transitioned kerberos after an
initial connect to the client. Starting with MongoDB 4.0, this
simply will not work anymore, and needs to be corrected.

NODE-1479

The SSPI auth process should have been the same as GSSAPI, but
it instead initialized and transitioned kerberos _after_ an
initial connect to the client. Starting with MongoDB 4.0, this
simply will not work anymore, and needs to be corrected.

NODE-1479
Copy link
Contributor

@daprahamian daprahamian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine for a quick fix, but can we in the future unify GSSAPI and SSPI into one?

@mbroadst
Copy link
Member Author

mbroadst commented Oct 30, 2018

Yep, please make a jira ticket for that. The customer report was that linux worked perfectly, and sspi did not, so I didn't want to touch the working path.

Note, this is related to moving the authentication processes out of the kerberos module, and embedding them directly into the driver. There is a lot of hidden implementation detail here, and both of those processes should use the new common api provided for both SSPI/GSSAPI by the updated 1.x version of the kerberos module

Copy link
Contributor

@kvwalker kvwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@mbroadst mbroadst merged commit 808ab21 into master Oct 31, 2018
@mbroadst mbroadst deleted the NODE-1479/fix-sspi-auth-workflow branch October 31, 2018 13:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants